This repository was archived by the owner on Jan 22, 2025. It is now read-only.
chore: fix failing getBlockTime integration test#11825
Merged
Merged
Conversation
jstarry
added
automerge
Codecov Report
@@ Coverage Diff @@
## master #11825 +/- ##
==========================================
- Coverage 82.0% 69.8% -12.3%
==========================================
Files 330 28 -302
Lines 77298 1378 -75920
Branches 0 172 +172
==========================================
- Hits 63425 962 -62463
+ Misses 13873 369 -13504
- Partials 0 47 +47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Seems that #10630 caused a regression where the first block is no longer timestamped. This causes the getBlockTime integration test to fail because it asserts that the first block has a timestamp
Summary of Changes
Fixes #